> Mostly OK, my only comment is about the comments! There's a couple of > places where the comments are phrased in terms of "this commit" and > "see changes". Comments in the code should (I think) be phrased in > terms of how the code is right now (or at least after the changes is > merged), so: > > (see changes to arc_frame_pointer_required) > > becomes > > (see arc_frame_pointer_required) > > while: > > This issue is fixed in this commit too. > > can probably be deleted completely. >
Committed with the additional suggestions. Thank you for your review, Claudiu
