Hi, On 9 November 2017 at 00:25, Jeff Law <l...@redhat.com> wrote: > On 11/08/2017 10:36 AM, Nathan Sidwell wrote: >> On 11/02/2017 04:33 PM, Nathan Sidwell wrote: >>> On 10/26/2017 10:34 AM, David Malcolm wrote: >>>> [CCing Rainer and Mike for the gcc-dg.exp part] >>> >>>> My Tcl skills aren't great, so hopefully someone else can review this; >>>> CCing Rainer and Mike. >>> >>> Ping? >>> >>> https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01911.html >>> >> Ping? A change to the column-checking logic the diagnostic processing. > I'm not sure anyone's Tcl skills are great these days. I think most of > us bash on it until it works the way we want and then try to return to > productive work :-) > > If David's happy with the changes to the diagnostic machinery, then > let's go ahead and move forward with this patch. > > jeff
I have just committed (r254949) the attached patch to fix a regression in the arm tests after this was committed (r254691). I hope it's obvious enough. Christophe
2017-11-20 Christophe Lyon <christophe.l...@linaro.org> gcc/testsuite/ * gcc.target/arm/pr69180.c: Use -: for no column in expected warnings.
diff --git a/gcc/testsuite/gcc.target/arm/pr69180.c b/gcc/testsuite/gcc.target/arm/pr69180.c index a43d0fe..1e978ef 100644 --- a/gcc/testsuite/gcc.target/arm/pr69180.c +++ b/gcc/testsuite/gcc.target/arm/pr69180.c @@ -8,10 +8,10 @@ #pragma GCC target ("fpu=neon-fp-armv8") #define __ARM_NEON_FP 0 -/* { dg-warning ".__ARM_NEON_FP. redefined" "" { target *-*-* } .-1 } */ +/* { dg-warning "-:.__ARM_NEON_FP. redefined" "" { target *-*-* } .-1 } */ #define __ARM_FP 0 -/* { dg-warning ".__ARM_FP. redefined" "" { target *-*-* } .-1 } */ +/* { dg-warning "-:.__ARM_FP. redefined" "" { target *-*-* } .-1 } */ #define __ARM_FEATURE_LDREX 0 -/* { dg-warning ".__ARM_FEATURE_LDREX. redefined" "" { target *-*-* } .-1 } */ +/* { dg-warning "-:.__ARM_FEATURE_LDREX. redefined" "" { target *-*-* } .-1 } */