On Sun, Nov 19, 2017 at 11:11 PM, Thomas Koenig <tkoe...@netcologne.de> wrote: > There is one question regarding the ABI. Apparently, the string length > is passed as an int even on a 64-bit system. I verified that this > is indeed the case by doing the actual work on a > powerpc64-unknown-linux-gnu box (gcc110 on the gcc compile farm), > which is big-endian. If we were actually passing an eight-byte > quantity, and only getting the upper bytes, we would crash & burn. > > Now, I _thought_ we were passing string lengths as size_t now (Janne?), > but maybe something was missing in that change.
Unfortunately I had to revert the charlen->size_t patch since it caused regressions on aix/power (presumably due to endianness issues). I did fix a potential bug there, but I never got any response to my request to get an account on the gcc compile farm to test it, and gcc 7 stage3 was closing so I ran out of time. There's apparently some other process for getting compile farm accounts nowadays, and we have broken the ABI again for gcc 8, so maybe I should dust off the patch and try again. Or what do you think? -- Janne Blomqvist
