On 11/15/2017 11:58 PM, Nathan Rossi wrote: > Remove the MicroBlaze specific TARGET_ASM_OUTPUT_IDENT definition, and > use the default. > > This resolves issues associated with the use of the .sdata2 operation in > cases where emitted assembly after the ident output is incorrectly in > the .sdata2 section instead of .text or any other expected section. > Which results in assembly failures including operations with symbols > across different segments. > > gcc/ChangeLog > > 2017-11-16 Nathan Rossi <nat...@nathanrossi.com> > > PR target/83013 > * config/microblaze/microblaze-protos.h > (microblaze_asm_output_ident): Delete > * config/microblaze/microblaze.c (microblaze_asm_output_ident): Delete > * config/microblaze/microblaze.h (TARGET_ASM_OUTPUT_IDENT): Default But isn't the purpose of the override to force certain small-enough objects into the .sdata2 section and by removing the override aren't you losing that capability?
It does seem like the override is broken in that it changes the current section behind the back of the generic code. Wouldn't a better fix be to ensure that the override arranges to switch back to whatever the current section is? Perhaps using .pushsection and .popsection would help here? jeff
