Hi!
On Thu, Nov 09, 2017 at 03:42:42PM -0800, Carl Love wrote:
> * config/rs6000/rs6000-c.c (altivec_overloaded_builtins):
> Add support for builtins:
> unsigned int vec_first_{,miss}_match_{,or_eos}index (
Don't end a line with an opening parenthesis.
> vector {un,}signed {char,int,short},
> vector {un,}signed {char,int,short}) arguments.
> * config/rs6000/rs6000-builtin.def (VFIRSTMATCHINDEX,
> VFIRSTMATCHOREOSINDEX, VFIRSTMISMATCHINDEX, VFIRSTMISMATCHOREOSINDEX):
> Add BU_P9V_AV_2 expansions for the builtins.
> * config/rs6000/altivec.h (vec_first_match_index,
> vec_first_mismatch_index, vec_first_match_or_eos_index,
> vec_first_mismatch_or_eos_index): Add #defines for the builtins.
> * config/rs6000/rs6000-protos.h (bytes_in_mode): Add
> new extern declaration.
There's a tab character there.
> * gcc.target/powerpc/vsu/vec-cnttz-lsbb-2.c (dg-error): Add _v16qi to
> __builtin_altivec_vctzlsbb.
"dg-error" is not a function name or similar; there can be many such
statements with the same name even! I'd do something like
* gcc.target/powerpc/vsu/vec-cnttz-lsbb-2.c: Adjust expected error
message.
> + first_mismatch_index_v16qi)
> +BU_P9V_AV_2 (VFIRSTMISMATCHINDEX_V8HI, "first_mismatch_index_v8hi", CONST,
> + first_mismatch_index_v8hi)
> +BU_P9V_AV_2 (VFIRSTMISMATCHINDEX_V4SI, "first_mismatch_index_v4si", CONST,
> + first_mismatch_index_v4si)
> +BU_P9V_AV_2 (VFIRSTMISMATCHOREOSINDEX_V16QI,
> "first_mismatch_or_eos_index_v16qi",
> + CONST, first_mismatch_or_eos_index_v16qi)
> +BU_P9V_AV_2 (VFIRSTMISMATCHOREOSINDEX_V8HI,
> "first_mismatch_or_eos_index_v8hi", CONST,
> + first_mismatch_or_eos_index_v8hi)
> +BU_P9V_AV_2 (VFIRSTMISMATCHOREOSINDEX_V4SI,
> "first_mismatch_or_eos_index_v4si", CONST,
> + first_mismatch_or_eos_index_v4si)
Some of those lines are too long; there's not terribly much you can do
about that, but you have moved "CONST" to the next line in one case and not
in others? And that last line is unaligned (has a space to many).
Other than those nits it looks fine. Please commit to trunk. Thanks!
Segher
