On Mon, Nov 6, 2017 at 11:01 AM, Jim Wilson <j...@sifive.com> wrote: > On 10/31/2017 12:11 PM, David Edelsohn wrote: >> >> With your recent removal of SDB and -gcoff support, I would appreciate >> your advice about my patch to incrementally add some preliminary LTO >> support for AIX to collect2.c: >> >> https://gcc.gnu.org/ml/gcc-patches/2017-10/msg00893.html >> >> There don't seem to be any other COFF targets around that still use >> the collect2 code to manually scan object and archive files. And I >> don't think that they would be hurt by the additional search for the >> LTO symbol. I want to check if anyone is aware of a potential problem >> before I commit the code. > > > The patch is OK. > > cygwin uses collect2, but it is using the generic support, not the COFF > specific support. > > The generic support has a check for to verify that we have an object file > and not an archive file. See maybe_lto_object_file. You might want to add > equivalent code to the COFF support.
On AIX, archive files can be processed as a series of object files and collect2.c:scan_prog_file() explicitly utilizes this. LTO object files can be in archives. Thanks for checking the patch. - David
