Hi Carl,
On Thu, Nov 02, 2017 at 12:54:57PM -0700, Carl Love wrote:
> 2017-11-01 Carl Love <c...@us.ibm.com>
>
> * config/rs6000/rs6000-c.c (P8V_BUILTIN_VEC_REVB): Add power 8
> definitions.
> (P9V_BUILTIN_VEC_REVB): Remove the power 9 instance definitions.
> * config/rs6000/altivec.h (vec_revb): Change the #define from power 9
> to power 8.
> * config/rs6000/r6000-protos.h (swap_selector_for_mode): Add extern
> declaration.
swap_endian_selector_for_mode, and just "New" or "New declaration"
please.
> * config/rs6000/rs6000.c (swap_endianess_selector_for_mode): Add
> function.
"New" or "New function". And spelling of the function name.
> +(define_mode_attr VSX_XXBR [(V8HI "h")
> + (V4SI "w")
Please make V4SI line up with V8HI.
> +;; Swap all bytes in each element of vector
> +(define_expand "revb_<mode>"
> + [(set (match_operand:VEC_REVB 0 "vsx_register_operand")
> + (bswap:VEC_REVB (match_operand:VEC_REVB 1 "vsx_register_operand")))]
> + ""
> +{
> + rtx sel;
Declare it at its first use please:
> + sel = swap_endian_selector_for_mode(<MODE>mode);
rtx sel = swap_endian_selector_for_mode(<MODE>mode);
Okay for trunk with those changes. Thanks!
Segher
