On 10/26/2017 06:30 PM, Sandra Loosemore wrote:
On 10/26/2017 01:21 AM, Martin Liška wrote:
On 10/20/2017 06:03 AM, Sandra Loosemore wrote:
On 10/19/2017 12:26 PM, Eric Gallager wrote:
On 10/19/17, Martin Liška <mli...@suse.cz> wrote:
Hi.
As discussed in the PR, we should be more precise in our documentation.
The patch does that.
Ready for trunk?
Martin
gcc/ChangeLog:
2017-10-19 Martin Liska <mli...@suse.cz>
PR gcov-profile/82457
* doc/invoke.texi: Document that one needs a non-strict ISO mode
for fork-like functions to be properly instrumented.
---
gcc/doc/invoke.texi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
The wording is kinda unclear because the modes in the parentheses are
all strict ISO modes, but the part before the parentheses says
NON-strict... I think you either need an additional "not" inside the
parentheses, or to change all the instances of -std=c* to -std=gnu*.
The wording in the patch doesn't make sense to me, either. If I understand the
issue correctly, the intent is probably to say something like
Unless a strict ISO C dialect option is in effect,
@code{fork} calls are detected and correctly handled without double counting.
??
Hi Sandra.
Thank you for the feedback, I'm sending version you suggested. Hope it's fine
to install the patch?
Ummm, no. Sorry to have been unclear; the wording I suggested above was
intended to replace the existing sentence about fork behavior, not to be
appended to it.
-Sandra
Sorry, stupid mistake. Should be fixed, I'm going to install the patch.
Martin
>From 30a3987aae8d306764bf38037f3f197cfe0d2aef Mon Sep 17 00:00:00 2001
From: marxin <mli...@suse.cz>
Date: Thu, 19 Oct 2017 12:18:45 +0200
Subject: [PATCH] Document --coverage and fork-like functions (PR
gcov-profile/82457).
gcc/ChangeLog:
2017-10-19 Martin Liska <mli...@suse.cz>
PR gcov-profile/82457
* doc/invoke.texi: Document that one needs a non-strict ISO mode
for fork-like functions to be properly instrumented.
---
gcc/doc/invoke.texi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 71b2445f70f..6ca59baac67 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -10862,9 +10862,9 @@ Link your object files with @option{-lgcov} or @option{-fprofile-arcs}
Run the program on a representative workload to generate the arc profile
information. This may be repeated any number of times. You can run
concurrent instances of your program, and provided that the file system
-supports locking, the data files will be correctly updated. Also
-@code{fork} calls are detected and correctly handled (double counting
-will not happen).
+supports locking, the data files will be correctly updated. Unless
+a strict ISO C dialect option is in effect, @code{fork} calls are
+detected and correctly handled without double counting.
@item
For profile-directed optimizations, compile the source files again with
--
2.14.2
