On Wed, Oct 25, 2017 at 08:10:45PM +0000, Joseph Myers wrote:
> On Wed, 25 Oct 2017, Michael Meissner wrote:
>
> > +static const char *const fltfn_suffixes[] = { "F16", "F32", "F128", "F32X",
> > + "F64X", "F128X", NULL };
>
> I'd expect this to include F64. If there's some reason that's
> inappropriate and the omission is deliberate, it needs a detailed comment
> explaining the omission.
Thanks for catching this. I missed F64.
> I don't think that, given the availability of fmaf128 etc. built-in
> functions with appropriate options, whether __FP_FAST_* are defined should
> actually depend on whether the user has passed options to disable those
> functions (after all, it doesn't for the existing fma / fmaf / fmal, and
> individual built-in functions can be disabled with -fno-builtin-<function>
> so the logic you have wouldn't work to detect whether the built-in
> function is disabled anyway).
Ok, I will add a check to see if the functions are disabled.
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797
