Thanks for looking at this Frederic, I don't see your name in the MAINTAINERS list so I assume I still need approval from one of the diagnostic message maintainers (Dodji or David) or maybe an Aarch64 maintainer or a global maintainer.
Ping? Steve Ellcey sell...@cavium.com On Sun, 2017-10-08 at 13:17 +0200, Frédéric Marchal wrote: > Sorry for the delay. I lost track of this discussion. > > The patch looks good to me. > > I haven't checked the unit tests because I don't understand them. I > assume they all succeed when you run the tests so they are all ok. > > I don't remember seeing a definite answer about the C-only syntax > used in error messages. If nobody complains, then I don't mind. I > have no solution to propose anyway. > > Thanks for you patch, > > Frederic > > > On Friday 06 October 2017 15:23:38 Steve Ellcey wrote: > > Ping. > > > > Steve Ellcey > > sell...@cavium.com > > > > On Mon, 2017-09-25 at 16:25 -0700, Steve Ellcey wrote: > > > This is a new version of my patch to fix PR target/79868, where > some > > > error messages are impossible to translate correctly due to how > the > > > strings are dynamically constructed. It also includes some > format > > > changes in the error messags to make the messages more consistent > with > > > each other and with other GCC errors. This was worked out with > help > > > from Martin Sebor. I also had to fix some tests to match the new > error > > > string formats. > > > > > > Tested on Aarch64 with no regressions, OK to checkin? > > > > > > Steve Ellcey > > > sell...@cavium.com > > > > > > > > > 2017-09-25 Steve Ellcey <sell...@cavium.com> > > > > > > PR target/79868 > > > * config/aarch64/aarch64-c.c > (aarch64_pragma_target_parse): > > > Change argument type on aarch64_process_target_attr call. > > > * config/aarch64/aarch64-protos.h > > > > > > (aarch64_process_target_attr): > > > Change argument type. > > > * config/aarch64/aarch64.c (aarch64_attribute_info): > Change > > > field type. > > > (aarch64_handle_attr_arch): Change argument type, use > boolean > > > argument to use different strings in error calls. > > > (aarch64_handle_attr_cpu): Ditto. > > > (aarch64_handle_attr_tune): Ditto. > > > (aarch64_handle_attr_isa_flags): Ditto. > > > (aarch64_process_one_target_attr): Ditto. > > > (aarch64_process_target_attr): Ditto. > > > (aarch64_option_valid_attribute_p): Change argument type > on > > > aarch64_process_target_attr call. > > > > > > 2017-09-25 Steve Ellcey <sell...@cavium.com> > > > > > > PR target/79868 > > > * gcc.target/aarch64/spellcheck_1.c: Update dg-error > string to > > > > > > match > > > > > > new format. > > > * gcc.target/aarch64/spellcheck_2.c: Ditto. > > > * gcc.target/aarch64/spellcheck_3.c: Ditto. > > > * gcc.target/aarch64/target_attr_11.c: Ditto. > > > * gcc.target/aarch64/target_attr_12.c: Ditto. > > > * gcc.target/aarch64/target_attr_17.c: Ditto. >
