On 10/18/2017 06:08 PM, Aldy Hernandez wrote:
> Also, do we have a blessed way of specifying overloaded functions in
> ChangeLog's? I couldn't find anything in our GCC coding guidelines or
> in the GNU coding guidelines. For lack of direction, I'm doing the
> following:
>
> * wide-int.cc (debug) [const wide_int &]: New.
> (debug) [const wide_int *]: New.
> (debug) [const widest_int &]: New.
> (debug) [const widest_int *]: New.
>
> It seems appropriate, as that is the GNU way of changelogs for a
> conditional change to a function ???.
Doesn't seem that appropriate to me. Square brackets are used for
conditional compilation (#ifdef etc.), but overloads are not that.
I'd suggest looking in libstdc++'s ChangeLog for precedents. It's where
I looked at when I had the same question for GDB, FWIW. E.g., a very
recent libstdc++ commit from Jon had:
* include/bits/stl_map.h (map::insert(value_type&&))
(map::insert(const_iterator, value_type&&)): Add overload for rvalues.
I.e., simply use the full prototype as function name, since it's
really what it is in C++.
Thanks,
Pedro Alves
