On Tue, Oct 17, 2017 at 01:09:50PM +0000, Koval, Julia wrote: > Hi, this the third patch of GFNI ISASET enabling. It enables GF2P8AFFINE > instruction, described here: > https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf > > gcc/ > * config/i386/gfniintrin.h (_mm_gf2p8affine_epi64_epi8, > _mm256_gf2p8affine_epi64_epi8,
Too long line, even ChangeLog entries should be wrapped to 80 columns. > (_mm_mask_gf2p8affine_epi64_epi8, _mm_maskz_gf2p8affine_epi64_epi8, > _mm256_mask_gf2p8affine_epi64_epi8, _mm256_maskz_gf2p8affine_epi64_epi8, > _mm512_mask_gf2p8affine_epi64_epi8, _mm512_maskz_gf2p8affine_epi64_epi8, The above two are also too long (off by 1 char). > _mm512_gf2p8affine_epi64_epi8): New intrinsics. > * config/i386/i386-builtin.def (__builtin_ia32_vgf2p8affineqb_v64qi, > __builtin_ia32_vgf2p8affineqb_v32qi, > __builtin_ia32_vgf2p8affineqb_v16qi): New builtins. And this one too. Please wrap them. > * config/i386/sse.md (vgf2p8affineqb_*): New pattern. Use vgf2p8affineqb_<mode><mask_name> instead of the wild-card? I'll defer actual review to Kirill. Jakub