Hi Will,
On Mon, Oct 09, 2017 at 04:27:54PM -0500, Will Schmidt wrote:
> Fix up a few issues with the tests.
> - add -O2 to int128-p8 test, and firm up the -mcpu options
> - update the set of expected instructions for the int128-p9 test.
> - replace the float128_hw requirement with power8_vector_ok
> for the int128-p9 test.
> -/* { dg-final { scan-assembler-times "\[ \t\]mulld " 6 } } */
> +/* { dg-final { scan-assembler-times "\[ \t\]mulld" 6 } } */
Why this? (Better/easier would be to use \m and \M btw.)
> diff --git a/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p9.c
> b/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p9.c
> index e81ea5f..a226ae0 100644
> --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p9.c
> +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p9.c
> @@ -1,10 +1,10 @@
> /* Verify that overloaded built-ins for vec_mul with __int128
> inputs produce the right results. */
>
> /* { dg-do compile } */
> -/* { dg-require-effective-target powerpc_float128_hw_ok } */
> +/* { dg-require-effective-target powerpc_p8vector_ok } */
> /* { dg-require-effective-target int128 } */
> /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } {
> "-mcpu=power9" } } */
> /* { dg-options "-mcpu=power9 -O2" } */
> /* { dg-additional-options "-maix64" { target powerpc-ibm-aix* } } */
This looks curious, too. With the change it will no longer work if you
built GCC with a version of binutils that doesn't support p9, I think?
Not that people should do that.
Segher
