On 29/09/17 21:29, Steve Ellcey wrote: > On Thu, 2017-09-28 at 12:31 +0100, Szabolcs Nagy wrote: >> >> i think this should be improved, see below. > > Those were all good suggestions, here is a new patch that incorporates > the changes. I fixed the IFUNC_OPTIONS argument, > renamed ARCH_AARCH64_LINUX_LSE, got rid of the auxv references, and > changed HWCAP_TYPE to IFUNC_RESOLVER_ARGS. > > Here is the new patch, tested with no regressions. >
looks good to me, but i cannot approve. (this will make libatomic depend on ifuncs on aarch64*-linux-gnu.) > Steve Ellcey > sell...@cavium.com > > > 2017-09-29 Steve Ellcey <sell...@cavium.com> > > * Makefile.am (ARCH_AARCH64_LINUX): Add IFUNC_OPTIONS and > libatomic_la_LIBADD. > * config/linux/aarch64/host-config.h: New file. > * configure.ac (IFUNC_RESOLVER_ARGS): Define. > (ARCH_AARCH64_LINUX): New conditional for IFUNC builds. > * configure.tgt (aarch64): Set ARCH and try_ifunc. > (aarch64*-*-linux*) Update config_path. > (aarch64*-*-linux*) Set IFUNC_RESOLVER_ARGS. > * libatomic_i.h (GEN_SELECTOR): Add IFUNC_RESOLVER_ARGS argument. > * Makefile.in: Regenerate. > * auto-config.h.in: Regenerate. > * configure: Regenerate. >
