>>>>> "Alexander" == Alexander Monakov <amona...@ispras.ru> writes:
Alexander> This hunk reverts CXX17 back to CXX1Z. Thanks for noticing, I'd written this before Jakub's patch and so the error came in during the rebase. Alexander> These two hunks add more duplication in already-duplicated 'if' statement Alexander> bodies. Is it possible to move the whole body to a separate function? I suppose, but this is just copying what pre-existing code does. Alexander> I guess the references to C++11 and C99 are duplicated from the preceding 'if', Alexander> but is that correct here? And why is it useful to distinguish between C and C++ Alexander> for this error in the first place, why not simply say 'cpp_error (..., Alexander> "__VA_OPT__ can only appear in the expansion of a variadic macro");'? I don't really understand the rationale for why the errors are phrased the way they are, but I notice the C errors generally mention C99 and the C++ errors generally mention C++11. So, since I didn't have a rationale, I copied what is already there. I thought maybe GCC is just emitting the default standard choice for each language. Tom