On Tue, 12 Sep 2017, Nathan Sidwell wrote: > On 09/12/2017 12:06 PM, Joseph Myers wrote: > > On Tue, 12 Sep 2017, Nathan Sidwell wrote: > > > > This patch removes that checking, and also asserts that when we see > > > identically named decls, exactly one is a TYPE_DECL. > > > > When do you get TYPE_DECLs here, for C? I wouldn't expect them to be > > possible. > > > > oh, of course (C is so primitive!). This patch survives a bootstrap, ok?
I'd be concerned about the possibility of a qsort implementation that calls the comparison function with two pointers to the same object (as far as I can tell, it's valid for qsort to do that). That is, I think you need to check for the two DECLs being the same DECL, before asserting their names are different. -- Joseph S. Myers jos...@codesourcery.com
