> On 4 Sep 2017, at 21:48, Jakub Jelinek <ja...@redhat.com> wrote: > > On Mon, Sep 04, 2017 at 08:47:07PM +0100, Simon Wright wrote: >> On 1 Sep 2017, at 23:05, Simon Wright <si...@pushface.org> wrote: >>> >>> 2017-09-01 Simon Wright <si...@pushface.org> >>> >>> PR target/80204 >>> * config/darwin-driver.c (darwin_find_version_from_kernel): eliminate >>> calculation of the >>> minor version, always output as 0. >> >> Like this? >> >> Do you need the patch to be resubmitted as well? >> >> gcc/Changelog >> >> 2017-09-01 Simon Wright <si...@pushface.org> >> >> PR target/80204 >> * config/darwin-driver.c (darwin_find_version_from_kernel): >> Eliminate calculation of the minor version, always output as 0. > > Better > > 2017-09-01 Simon Wright <si...@pushface.org> > > PR target/80204 > * config/darwin-driver.c (darwin_find_version_from_kernel): Eliminate > calculation of the minor version, always output as 0. > > Jakub
Very sorry that no-one from the Darwin folks has reviewed this to date, and thanks for the patch (and to Jakub and Jeff for taking care of it). In general, I would prefer that a change like this would be made to apply to only versions of Darwin >= to the ones affected (so that the behaviour for earlier versions is unchanged). As I read your patch, it alters things for all versions. Having said that, the risk of bad effects is fairly low, and we can deal with them if they occur, so it’s a reasonable patch (as has been OK’d). Please CC me directly on Darwin patches; in case I miss them in other list traffic. Whilst I cannot approve them - at least I will try to review and make suggestions. Iain Sandoe CodeSourcery / Mentor Embedded / Siemens
