On Tue, 5 Sep 2017, Uros Bizjak wrote: > Revised patch, incorporates fixes from Alexander's review comments. > > I removed some implementation details from Alexander's description of > memory_blockage named pattern.
Well, to me it wasn't really obvious why a named pattern was needed in the first place, so I wish the explanation could stay in some form. One small nit, the new function comment in optabs.c, +/* Do not propagate memory accesses across this point. */ doesn't seem appropriate, it should probably say something like /* Emit an insn acting as a compiler memory barrier. */ Rest of the patch looks fine to me (but I cannot approve it). Thanks. Alexander
