On Fri, Sep 01, 2017 at 02:23:39PM +0100, Tamar Christina wrote: > Hi All, > > This patch enables tests for Dot Product vectorization > in gcc for ARM and AArch64. > > The ARMv8.2-a Dot Product instructions only support 8-bit > element vectorization. > > Dot product is available from ARMv8.2-a and onwards. > > Regtested and bootstrapped on aarch64-none-elf and > arm-none-eabi and no issues.
I'm surprised that this worked! It looks like you unconditionally add the -march=armv8.2-a+dotprod options, which should cause you to generate instructions which will not execute on targets which don't support this instruction. As far as I can see, this is an execute test, so that should cause undefined instruction exceptions on an Armv8-A target at the very least. So, not OK in its current form. Thanks, James > > Ok for trunk? > > gcc/testsuite > 2017-09-01 Tamar Christina <tamar.christ...@arm.com> > > * gcc.dg/vect/vect-reduc-dot-s8a.c > (dg-additional-options, dg-require-effective-target): Add +dotprod. > * gcc.dg/vect/vect-reduc-dot-u8a.c > (dg-additional-options, dg-require-effective-target): Add +dotprod. > > --
