On 08/01/2017 02:56 AM, Tsimbalist, Igor V wrote: > Part#3. Add tests for -finstrument-control-flow and notrack attribute. > > > 0003-Part-3.-Add-tests-for-finstrument-control-flow-and-n.patch > > > From 7869de8a0c0ec55c4e9240c2483fefee97bf34c9 Mon Sep 17 00:00:00 2001 > From: Igor Tsimbalist <igor.v.tsimbal...@intel.com> > Date: Mon, 3 Jul 2017 17:29:08 +0300 > Subject: [PATCH 3/9] Part#3. Add tests for -finstrument-control-flow and > notrack attribute. > > gcc/testsuite/ > > * c-c++-common/finstrument-control-flow.c: New test. > * c-c++-common/notrack-1.c: Likewise. > * c-c++-common/notrack-2.c: Likewise. No concerns with the existing tests.
We should consider an ICF test as I outlined in an earlier message. We should also consider tests where we drop/add the notrack attribute as ISTM we ought to be getting warnings in those cases. Finally, you should consider tests in gcc.target/i386 that verify we generate the proper instrumentation for a few tests. jeff
