-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/05/11 14:48, Bernd Schmidt wrote: > This adds a little mini-pass to shrink-wrapping, to eliminate a > common case that often makes shrink-wrapping unavailable. If a move > insn copies an argument registers to a call-saved register, the > prologue must be emitted before this insn. We should therefore try > to delay such moves for as long as possible. > > A followup patch will add an extra cprop pass, which replaces uses > of the call-saved register with uses of the incoming argument > register, thereby allowing us to move the copies in even more > cases. > > Bootstrapped and tested on i686-linux. Ok? Just a couple comments.
Inside bb_active_p there's a comment referring to "last block", which should be BB. Just a nit that didn't get changed when ractoring that code out of thread_prologue_and_epilogue_insns. In the loop over edges within prepare_shrink_wrap, I think a comment is warranted. If I read the code correctly you're looking for the case where the destination register is live on one and only one edge, right? But it'd be easier if there was just a comment to that effect. OK with the two comment fixes. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOjgy0AAoJEBRtltQi2kC72RgH/1xTWE3Ixeu5KXbjb2UUa8G8 dBnlfL811DjASLLD07ubZRqbaimaj4EMW1QE4sXK0pqUWV62Rmoc82F3+dy+PfFd qhl+ES4lwJHyHj562DfuIL9JHcjRYGXEoxcSEu2M7+iwMBZQADkcirY2qTAgd+ea aogM2dnJbaHacgh0xw21r8AF0ZfjVrA1jZ0co4weDeTV4kiEccL+QgTjvLNDT/CV awxkjpminrBi2zM6ERaukKh3ebkfLwXlOvHJTvDQvH+oDPsxZBQ0JqoMDRGlOkEf soe7IF+eIwuWOUFr5Z1+7o/FQcsELwY9v6tceEudA/hHtJEk6MWtMGGXDSRhqWk= =afiG -----END PGP SIGNATURE-----
