Hi!

Sorry the review took a while.

On Fri, Aug 11, 2017 at 12:28:16PM +0930, Alan Modra wrote:
>       * config/rs6000/rs6000.c (rs6000_savres_strategy): Don't restore
>       fixed regs.

> diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
> index 74158cd..b628808 100644
> --- a/gcc/config/rs6000/rs6000.c
> +++ b/gcc/config/rs6000/rs6000.c
> @@ -24309,6 +24309,7 @@ rs6000_savres_strategy (rs6000_stack_t *info,
>                       bool using_static_chain_p)
>  {
>    int strategy = 0;
> +  int i;

Let's not move declarations to three screens before the first use.  You
can conveniently declare the loop counters straight in the "for" itself,
like  for (int i = 0; i < n; i++)  .

Okay for trunk, with that improvement please.


Segher

Reply via email to