On 07/20/2017 08:40 AM, Alexander Monakov wrote:
> Hi,
>
> Segher pointed out on IRC that ICE reporting with dumps enabled got worse:
> if emergency_dump_function itself leads to an ICE (e.g. by segfaulting),
> nested ICE reporting will invoke emergency_dump_function in exactly the
> same context, but not only would we uselessly announce current pass again,
> this time around the second SIGSEGV will just terminate cc1 because the
> signal handler is unregistered (so we won't print the backtrace). Sorry
> for not really considering the implications when submitting that patch.
>
> Solve this by substituting the callback for global_dc->internal_error;
> this avoids invoking emergency_dump_function, and also gives a
> convenient point to flush the dump file. OK to apply?
>
> * topvel.c (dumpfile.h): New include.
> (internal_error_reentered): New static function. Use it...
> (internal_error_function): ...here to handle reentered internal_error.
OK.
jeff
