On 07/27/2017 08:33 PM, Yuri Gribov wrote: > On Wed, Jul 26, 2017 at 6:11 PM, Jeff Law <l...@redhat.com> wrote: >> On 07/09/2017 01:03 PM, Yuri Gribov wrote: >>> Hi, >>> >>> Currently mklog will fail to analyze lines like this in patches: >>> diff -rupN gcc/gcc/testsuite/lib/profopt.exp >>> gcc-compare-checks/gcc/testsuite/lib/profopt.exp >>> (it fails with "Error: failed to parse diff for ... and ..."). >>> >>> This patch fixes it. Ok for trunk? >>> >>> -Y >>> >>> >>> mklog-filename-fix-1.patch >>> >>> >>> 2017-07-09 Yury Gribov <tetra2...@gmail.com> >>> >>> contrib/ >>> * mklog: Fix extraction of changed file name. >> One could argue that given general directions python would be a better >> match than perl, but I don't think it's reasonable to require a rewrite >> to move forward. > > Jeff, > > Is this to make script more accessible for hacking by others? Precisely. In general I think folks here are more adept at python than perl.
> Otherwise from technical standpoint there probly isn't much > difference. Agreed. > > I'm fine with rewriting it in Python once I get some time later this month. Thanks. Saw that fly by, it's in the queue. jeff
