On 07/27/2017 02:43 AM, Richard Biener wrote:
> On Thu, Jul 27, 2017 at 10:30 AM, <tbsaunde+...@tbsaunde.org> wrote:
>> From: Trevor Saunders <tbsaunde+...@tbsaunde.org>
>>
>> The preC++ way of passing information about the call site of a function was
>> to
>> use a macro that passed __file__, __LINE__, and __FUNCTION__ to a function
>> with
>> the same name with _stat appended to it. The way this is now done with C++
>> is
>> to have arguments where the default value is __LINE__, __FILE__, and
>> __FUNCTION__ in the caller. This has the significant advantage that if you
>> look for "^function (" you find the correct function, where in the C way of
>> doing things you need to realize its a macro and check the definition of the
>> macro to see what to look for next. So this removes a layer of indirection,
>> and makes things somewhat more consistant in using the C++ way of doing
>> things.
>>
>> patches independently bootstrapped and regtested on ppc64le-linux-gnu. I
>> successfully ran make all-gcc with --enable-gather-detailed-mem-stats, but
>> couldn't complete a bootstrap before the series was applied, because the
>> ddrs_table in tree-loop-distribution.c causes memory statistics gathering to
>> crash before the series as well as after it. ok?
>
> Thanks! This was on my list of things todo...
>
> The series is ok.
Just wanted to relay a thanks from me too. I always find it annoying to
remember which functions are _stat thingies when debugging. No more!
Jeff
