On 07/28/2017 09:41 AM, H.J. Lu wrote:
On Fri, Jul 28, 2017 at 6:57 AM, Daniel Santos<daniel.san...@pobox.com>  wrote:
On 07/26/2017 02:03 PM, H.J. Lu wrote:
This patch caused:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81563
Hello.  I've rebased my patch set and I'm now retesting.  I'm afraid that
your changes are wrong because my my sp_valid_at and fp_valid_at functions
are wrong -- these are supposed to be for the base offset and not the CFA
offset, sorry about that.  This means that the check in choose_basereg (and
thus choose_baseaddr) have been wrong as well.  I'm retesting now.
Please check your change with gcc.target/i386/pr81563.c.

Thanks.

I'm still getting used to x86 stack math and and briefly I thought that my understanding of the CFA was wrong and that I had messed up sp_valid_at and fp_valid_at, but I was mistaken, so sorry for the false alarm. My rebased patches pass all tests, so it's OK.

Reply via email to