On 07/25/2017 02:49 PM, Jakub Jelinek wrote: > On Tue, Jul 18, 2017 at 10:38:50AM +0200, Martin Liška wrote: >> 2017-06-27 Martin Liska <mli...@suse.cz> >> >> PR sanitize/81186 > > 8 spaces instead of tab? > >> * function.c (expand_function_start): Set parm_birth_insn after >> static chain is initialized. > > I don't like this description, after all, parm_birth_insn was set > after static chain initialization before too (just not right after it > in some cases). The important change is that you've moved parm_birth_insn > before the nonlocal_goto_save_area setup code, so IMHO the ChangeLog entry > should say that.
Both notes fixed and the patch has been also installed to GCC 7 branch. Thanks, Martin > > As for the patch itself, there are many spots which insert some code > before or after parm_birth_insn or spots tied to the NOTE_INSN_FUNCTION_BEG > note, but I'd hope nothing inserted there can actually call functions that > perform non-local gotos, so I think the patch is fine. And for debug info > experience which is also related to NOTE_INSN_FUNCTION_BEG, I think the nl > goto save area is nothing that can be seen in the debugger unless you know > where it is, so the only change might be if you put a breakpoint on the end > of prologue (i.e. NOTE_INSN_FUNCTION_BEG) and call from inferios some > function that performs a non-local goto. I think there are no barriers > on that initialization anyway, so scheduler can move it around. > > Thus, ok for trunk/7.2 with the above suggested ChangeLog change. > > Jakub >
