On Wed, Oct 5, 2011 at 5:32 PM, Artem Shinkarov
<artyom.shinkar...@gmail.com> wrote:
> On Wed, Oct 5, 2011 at 5:28 PM, Joseph S. Myers <jos...@codesourcery.com> 
> wrote:
>> On Wed, 5 Oct 2011, Artem Shinkarov wrote:
>>
>>> Joseph, is it possible to commit the patch together with the space fixes?
>>
>> You should not commit whitespace fixes to lines not otherwise modified by
>> a patch, except in a separate commit that *only* has whitespace or other
>> formatting fixes, so that "svn blame" results are more meaningful.  That
>> is: commit whitespace fixes (assuming they are genuinely fixes rather than
>> making things worse) *separately* in a commit whose commit message makes
>> clear it is just whitespace fixes.
>
> Ok, I see.  In the given patch all the fixes are mainly auto-generated
> and remove the trailing spaces.  But I see your point.
>
> Thanks,
> Artem.
>> --
>> Joseph S. Myers
>> jos...@codesourcery.com
>>
>

Successfully regtested on x86-unknown-linux-gnu. Committed to the
mainline with the revision 179588.

ChangeLog:
2011-10-06  Artjoms Sinkarovs  <artyom.shinkar...@gmail.com>
        * c-tree.h (c_expr_t): New typedef for struct c_expr.
        (C_EXPR_APPEND): New macro.
        * c-parser.c (c_parser_get_builtin_args): Preserve
        original_tree_code of c_expr structure. Fixes bconstp-3.c
        failure of PR50607.
        (c_parser_postfix_expression): Adjust to the new function.


Artem.

Reply via email to