On Tue, 25 Jul 2017, Jakub Jelinek wrote: > Hi! > > I'd like to ping 2 patches: > > - UBSAN -fsanitize=pointer-overflow support > - http://gcc.gnu.org/ml/gcc-patches/2017-06/msg01365.html
The probablility stuff might need updating? Can you put the TYPE_PRECISION (sizetype) != POINTER_SIZE check in option processing and inform people that pointer overflow sanitizing is not done instead? Where you handle DECL_BIT_FIELD_REPRESENTATIVE in maybe_instrument_pointer_overflow you could instead of building a new COMPONENT_REF strip the bitfield ref and just remember DECL_FIELD_OFFSET/BIT_OFFSET to be added to the get_inner_reference result? You don't seem to use 'size' anywhere. You fail to allow other handled components -- for no good reason? You fail to handle &MEM[ptr + CST] a canonical gimple invariant way of ptr +p CST, the early out bitpos == 0 will cause non-instrumentation here. (I'd just round down in the case of bitpos % BITS_PER_UNIT != 0) Otherwise looks good. > - noipa attribute addition > > http://gcc.gnu.org/ml/gcc-patches/2016-12/msg01501.html > Ok. Thanks, Richard.
