On 07/16/2017 10:28 AM, Thomas Koenig wrote: > Am 14.07.2017 um 16:11 schrieb Cesar Philippidis: >> This patch teaches the fortran FE to allow deferred-shape pointers to be >> used in OpenACC data clauses. While the spec states that arrays must be >> contiguous, I believe that is a run-time requirement, not a compile >> time. The intent behind OpenACC is to have the programmer sprinkle a >> minimum amount of ACC directives on their existing code base, and have >> the compiler generate offloading code. In this case, the deferred-shape >> pointer check was preventing working code from compiling. > > It is possible to declare a pointer with the contiguous attribute. > Is there a reason that this cannot be used in general=
That's a good point. But some users don't want to modify their programs more beyond adding OpenACC directives. >> I was considering relaxing the error to a warning, but I ended up >> deciding this should be a run-time failure, if there is one. > > What happens - silent wrong-code or indeed a run-time error which > lets the user know what is wrong? It would be a run-time error, like a segmentation fault. >> Is this OK for trunk? I tested it on x86_64 with nvptx offloading. > > Does any of the gfortran maintaiers have access to a machine which > allows nvptx offloading? I lack both the hardware and the know-how :-) I don't know. Cesar