On Mon, Jul 10, 2017 at 10:32 AM, Thomas Preudhomme <thomas.preudho...@foss.arm.com> wrote: > Hi Yuri, > > On 09/07/17 20:06, Yuri Gribov wrote: >> >> Hi, >> >> Currently dg-cmp-results fails to compare fails in Asan tests because >> their output includes failing process id: >> NA->FAIL: c-c++-common/asan/bitfield-1.c -O0 output pattern test, >> is ==18161==ERROR >> FAIL->NA: c-c++-common/asan/bitfield-1.c -O0 output pattern test, >> is ==26667==ERROR >> >> This patch fixes this. I also did some fairly standard refactoring to >> improve stability and get rid of code dup. > > > I'm not familiar with asan but why not fix asan tests to not print the pid > instead?
The error message is printed by Asan runtime, not by tests themselves. Asan maintainers are typically unwilling to change output format of their messages as there may already be users who rely on it (e.g. using specific regexes in their scripts, etc.). Note that I'd very much rather fix the test (as I do in another patch here: https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00422.html). -Y
