On 4 July 2017 at 10:50, Christophe Lyon <christophe.l...@linaro.org> wrote: > On 3 July 2017 at 17:30, Jeff Law <l...@redhat.com> wrote: >> On 07/03/2017 09:00 AM, Christophe Lyon wrote: >>> Hi, >>> >>> This is a follow-up to >>> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01791.html >>> >>> This patch adds dg-require-stack-check and updates the tests that use >>> dg-options "-fstack-check" to avoid failures on configurations that to >>> not support it. >>> >>> I merely copied what we currently do to check if visibility flags are >>> supported, and cross-tested on aarch64 and arm targets with the >>> results I expected. >>> >>> This means that my testing does not cover the changes I propose for >>> i386 and gnat. >>> >>> Is it OK nonetheless? >>> >>> Thanks, >>> >>> Christophe >>> >>> >>> stack-check-et.chlog.txt >>> >>> >>> 2017-07-03 Christophe Lyon <christophe.l...@linaro.org> >>> >>> * lib/target-supports-dg.exp (dg-require-stack-check): New. >>> * lib/target-supports.exp (check_stack_check_available): New. >>> * g++.dg/other/i386-9.C: Add dg-require-stack-check. >>> * gcc.c-torture/compile/stack-check-1.c: Likewise. >>> * gcc.dg/graphite/run-id-pr47653.c: Likewise. >>> * gcc.dg/pr47443.c: Likewise. >>> * gcc.dg/pr48134.c: Likewise. >>> * gcc.dg/pr70017.c: Likewise. >>> * gcc.target/aarch64/stack-checking.c: Likewise. >>> * gcc.target/arm/stack-checking.c: Likewise. >>> * gcc.target/i386/pr48723.c: Likewise. >>> * gcc.target/i386/pr55672.c: Likewise. >>> * gcc.target/i386/pr67265-2.c: Likewise. >>> * gcc.target/i386/pr67265.c: Likewise. >>> * gnat.dg/opt49.adb: Likewise. >>> * gnat.dg/stack_check1.adb: Likewise. >>> * gnat.dg/stack_check2.adb: Likewise. >>> * gnat.dg/stack_check3.adb: Likewise. >> ACK once you address Rainer's comments. I've got further stack-check >> tests in the queue which I'll update once your change goes in. >> >> jeff > > Here is an updated version, which adds documentation for > dg-require-stack-check. > > I also ran make-check on and x86_64 with ada enabled and checked the logs: > the updated i386/* and gnat.dg* tests all pass, and are preceded by > the compilation > of the "stack_check" sample. > > OK?
Jeff, let me know if/when you want me to commit this? Thanks, Christophe > > Thanks, > > Christophe
