On Mon, Jul 3, 2017 at 5:52 AM, Martin Liška <mli...@suse.cz> wrote: > On 06/30/2017 09:34 PM, Jason Merrill wrote: >> On Fri, Jun 30, 2017 at 5:23 AM, Martin Liška <mli...@suse.cz> wrote: >>> This is v2 of the patch, where just names of attributes are canonicalized. >>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. >> >> What is the purpose of the new "strict" parameter to cmp_attribs* ? I >> don't see any discussion of it. > > It's needed for arguments of attribute names, like: > > /usr/include/stdio.h:391:62: internal compiler error: in cmp_attribs, at > tree.h:5523 > __THROWNL __attribute__ ((__format__ (__printf__, 3, 4))); >
Mm. Although we don't want to automatically canonicalize all identifier arguments to attributes in the parser, we could still do it for specific attributes, e.g. in handle_format_attribute or handle_mode_attribute. Jason
