Hi!
On Mon, 26 Jun 2017 17:29:11 +0200, Jakub Jelinek <ja...@redhat.com> wrote:
> On Mon, Jun 26, 2017 at 03:26:57PM +0000, Joseph Myers wrote:
> > On Mon, 26 Jun 2017, Tom de Vries wrote:
> >
> > > > 2. Handle GOMP_OPENACC_NVPTX_{DISASM,SAVE_TEMPS} in libgomp nvptx plugin
> > >
> > > This patch adds handling of:
> > > - GOMP_OPENACC_NVPTX_SAVE_TEMPS=[01], and
> > > - GOMP_OPENACC_NVPTX_DISASM=[01]
Why the "OPENACC" in these names? Doesn't this debugging aid apply to
any variant of offloading?
> > > The filename used for dumping the module is plugin-nvptx.<pid>.cubin.
Also, I suggest to make these names similar to their controlling options,
that is: "gomp-nvptx*", for example.
> > Are you sure this use of getenv and writing to that file is safe for
> > setuid/setgid programs? I'd expect you to need to use secure_getenv as in
> > plugin-hsa.c; certainly for anything that could results in writes to a
> > file like that.
>
> Yeah, definitely it should be using secure_getenv/__secure_getenv.
ACK.
> And IMNSHO GOMP_DEBUG too.
But why that? Isn't GOMP_DEBUG just controlling terminal debugging
output (that you'd also like to see in setuid/setgid programs)?
Grüße
Thomas
