> PING^1 > > Can you please Honza give a formal approval for the patch?
OK, thanks! Honza > > Thanks, > Martin > > On 06/22/2017 01:47 PM, Richard Biener wrote: > > On Thu, Jun 22, 2017 at 12:57 PM, Martin Liška <mli...@suse.cz> wrote: > >> On 06/22/2017 12:27 PM, Richard Biener wrote: > >>> On Wed, Jun 21, 2017 at 3:06 PM, Martin Liška <mli...@suse.cz> wrote: > >>>> Hello. > >>>> > >>>> There's one additional predictor enhancement that is GOTO predict that > >>>> used to working. Following patch adds expect statement for C and C++ > >>>> family > >>>> languages. > >>>> > >>>> There's one fallout which is vrp24.c test-case, where only 'Simplified > >>>> relational' > >>>> appears just once. Adding Richi and Patrick who can probably help how to > >>>> fix the > >>>> test-case. > >>> > >>> Happens to be optimized better now, there's only one predicate to simplify > >>> left in the IL input to VRP1. I suggest to change it to match 1 times > >>> and add > >>> -fdump-tree-optimized to dg-options and > >>> > >>> /* { dg-final { scan-tree-dump-times "if " 3 "optimized" } } */ > >>> > >>> to verify we have 3 conditions left. > >> > >> Thanks for help. > >> What about the comment: > >> > >> /* The first n_sets > 0 test can be simplfiied into n_sets == 1 since > >> n_sets can only have the values [0, 1] as it's the result of a > >> boolean operation. > >> > >> The second n_sets > 0 test can also be simplified into n_sets == 1 > >> as the only way to reach the tests is when n_sets <= 1 and the only > >> value which satisfies both conditions is n_sets == 1. */ > >> > >> I guess just only one can be valid? Or is it a different story now? > > > > The 2nd one is handled by earlier jump-threading. > > > >> Martin > >> > >>> > >>>> Patch can bootstrap on ppc64le-redhat-linux and survives regression > >>>> tests. > >>>> > >>>> Ready to be installed? > >>>> Martin > >>