Hello! > This patch to the gotools Makefile adds tests to `make check`. We now > test the runtime package using the newly built go tool, and test that > cgo works by running the misc/cgo/test and misc/cgo/testcarchive > tests. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. > Committed to mainline.
There are several failures on non-split targets, e.g.: FAIL: TestCgoHandlesWlORIGIN go_test.go:267: running testgo [build origin] go_test.go:286: standard error: go_test.go:287: # origin cc1: error: '-fsplit-stack' requires assembler support for CFI directives cc1: error: '-fsplit-stack' is not supported by this compiler configuration and: FAIL: TestCgoCrashHandler crash_test.go:70: building testprogcgo []: exit status 2 # _/home/uros/git/gcc/libgo/go/runtime/testdata/testprogcgo cc1: error: '-fsplit-stack' requires assembler support for CFI directives cc1: error: '-fsplit-stack' is not supported by this compiler configuration As evident from TestBuildDryRunWithCgo dump, -fsplit-stack argument is added unconditionally to the compile flags. Uros.