On Wed, May 31, 2017 at 02:38:15PM -0500, Will Schmidt wrote:
> Add support for early expansion of vector absolute built-ins.
> 
> [V2] Per reviews and feedback, skip the early folding for
> integral types based on a check against TYPE_OVERFLOW_WRAPS(arg0).
> 
> Added test variants to exercise the -fwrapv option during
> this folding.
> 
> OK for trunk?  (bootstraps running, pending review).

> +    /* flavors of vec_abs. */

Dot space space.

> +     if ( INTEGRAL_TYPE_P (TREE_TYPE (TREE_TYPE(arg0)))
> +         && ! TYPE_OVERFLOW_WRAPS (TREE_TYPE (TREE_TYPE(arg0))))
> +           return false;

No space after ( or !; space before ( in function calls (and macros, etc.)

Please fix those (and consider using contrib/check_GNU_style.py); and
then please commit.  Thanks,


Segher

Reply via email to