> Cc: gdb-patc...@sourceware.org > From: Pedro Alves <pal...@redhat.com> > Date: Fri, 19 May 2017 16:51:30 +0100 > > So again there's a system header that defines the symbol > but for some reason libiberty still wants to declare/define > it is if it weren't?
Yes. AFAICS, libiberty's configure script doesn't check the declaration, it only probes the setenv function itself. You can see that the cpp directives around the environ declarations are OS-dependent rather than based on autoconf tests. > That sounds to me like the root issue that should be fixed, > so that these fallback definitions don't come into into play at all. > I.e., why isn't HAVE_ENVIRON_DECL defined on mingw when > setenv.o is built? Sounds like a decl check is missing > in configure.ac. Most probably, yes.