Re: [PATCH] objc-runtime-shared-support.c - Identical code for different branches

Mon, 15 May 2017 18:15:13 -0700 

On 05/14/2017 03:58 AM, Sylvestre Ledru wrote:

Hello,

Now that Coverity is up and running, I am trying to fix some errors.

Let's start a trivial one (same code in different branches)

S



0001-2017-05-14-Sylvestre-Ledru-sylvestre-debian.org.patch


 From 50248decd02bfac52ad64b64c972750489e2ffa0 Mon Sep 17 00:00:00 2001
From: Sylvestre Ledru<sylves...@debian.org>
Date: Sun, 14 May 2017 10:55:24 +0200
Subject: [PATCH 1/5] 2017-05-14  Sylvestre Ledru<sylves...@debian.org>

        * objc-runtime-shared-support.c (build_module_descriptor):
           Identical code for different branches (since 2012)
           CID 1406758

OK.  BUt I would rewrite the ChangeLog as

        * objc-runtime-shared-support.c (build_module_descriptor):
        Remove unnecessary conditional when building instance of
        objc_module.

jeff

Reply via email to