On Mon, May 15, 2017 at 01:10:43PM -0700, Jerry DeLisle wrote:
> Hi all,
>
> Crash is a misnomer on this PR [aside: People see the backtrace and assume]
>
> This patch fixes the problem by correctly detecting the EOR condition for
> internal units. The previous check in read_sf_internal was wrong, relying
> probably on uninitialized memory as can be seen by the still open PR78881.
> Removing the bad hunk fixes the regression here and the new code lets
> dtio_26.f90 pass as expected.
>
> Regression tested on x86_64. New test case will be added.
>
> OK for trunk? Will back port in a few days to 7.
>
No. There are a number of other failures with your patch applied.
Running /home/sgk/gcc/gccx/gcc/testsuite/gfortran.dg/dg.exp ...
FAIL: gfortran.dg/read_3.f90 -O0 (test for excess errors)
FAIL: gfortran.dg/read_3.f90 -O1 (test for excess errors)
FAIL: gfortran.dg/read_3.f90 -O2 (test for excess errors)
FAIL: gfortran.dg/read_3.f90 -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions (test for excess errors)
FAIL: gfortran.dg/read_3.f90 -O3 -g (test for excess errors)
FAIL: gfortran.dg/read_3.f90 -Os (test for excess errors)
=== gfortran Summary ===
# of expected passes 6
# of unexpected failures 6
/mnt/sgk/objx/gcc/gfortran version 8.0.0 20170515 (experimental) (GCC)
--
Steve
20170425 https://www.youtube.com/watch?v=VWUpyCsUKR4
20161221 https://www.youtube.com/watch?v=IbCHE-hONow
