Hi Nathan On 11 May 2017 at 19:40, Nathan Sidwell <nat...@acm.org> wrote: > This patch reduces the variants of pushdecl by use of default arguments. > gone are the _maybe_friend variants. >
Since this commit (r247918), GCC builds fail at least for aarch64/arm. I've noticed this error message: libtool: compile: g++ -DHAVE_CONFIG_H -I. -I/tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1 -I /tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/li bcc1/../include -I /tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1/../libgcc -I ../gcc -I/tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1/.. /gcc -I /tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1/../gcc/c-family -I /tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1/../libcpp/includ e -I /tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1/../gcc/cp -I/tmp/3713244_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1/./ gmp -I/tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gmp -I/tmp/3713244_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1/./mpfr/src -I/ tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/mpfr/src -I/tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/mpc/src -W -Wall -fvisibility=hidden -g -O2 -MT libcp1plugin.lo -MD -MP -MF .deps/libcp1plugin.Tpo -c /tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1/libcp1plugin.cc -fPIC -DPIC -o .libs/libcp1plugin.o /tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1/libcp1plugin.cc: In function ‘tree_node* safe_pushdecl_maybe_friend(tree_node*, bool)’: /tmp/3713244_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libcc1/libcp1plugin.cc:815: error: ‘pushdecl_maybe_friend’ was not declared in this scope make[3]: *** [libcp1plugin.lo] Error 1 make[3]: Leaving directory `/tmp/3713244_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1/libcc1' I suspect it will be an obvious fix? Thanks, Christophe > nathan > -- > Nathan Sidwell