Richard Earnshaw (lists) wrote:
> --- a/gcc/config/arm/aarch-common.c
> +++ b/gcc/config/arm/aarch-common.c
> @@ -254,12 +254,7 @@ arm_no_early_alu_shift_dep (rtx producer, rtx consumer)
> return 0;
>
> if ((early_op = arm_find_shift_sub_rtx (op)))
> - {
> - if (REG_P (early_op))
> - early_op = op;
> -
> - return !reg_overlap_mentioned_p (value, early_op);
> - }
> + return !reg_overlap_mentioned_p (value, early_op);
>
> return 0;
> }
> This function is used by several aarch32 pipeline description models.
> What testing have you given it there. Are the changes appropriate for
> those cores as well?
arm_find_shift_sub_rtx can only ever return NULL_RTX or a shift rtx, so the
check for REG_P is dead code. Bootstrap passes on ARM too of course.
Wilco
