On April 19, 2017 12:55:24 PM GMT+02:00, "Martin Liška" <mli...@suse.cz> wrote:
>On 04/18/2017 08:05 PM, Sebastian Pop wrote:
>> On Mon, Apr 3, 2017 at 5:34 AM, Richard Biener <rguent...@suse.de>
>wrote:
>>> On Fri, 31 Mar 2017, Sebastian Pop wrote:
>>>
>>>> On Fri, Mar 31, 2017 at 12:06 PM, Richard Biener
><rguent...@suse.de> wrote:
>>> Does the following fix it?
>>>
>>> Index: gcc/auto-profile.c
>>> ===================================================================
>>> --- gcc/auto-profile.c (revision 246642)
>>> +++ gcc/auto-profile.c (working copy)
>>> @@ -1511,7 +1511,9 @@ afdo_vpt_for_early_inline (stmt_set *pro
>>>
>>> if (has_vpt)
>>> {
>>> - optimize_inline_calls (current_function_decl);
>>> + unsigned todo = optimize_inline_calls
>(current_function_decl);
>>> + if (todo & TODO_update_ssa_any)
>>> + update_ssa (TODO_update_ssa);
>>> return true;
>>> }
>>
>> Yes, this patch solves the problem, and this is also what Dehao has
>> suggested in his last comment in
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972
>>
>> Thanks,
>> Sebastian
>
>Hi.
>
>I've just tested the patch and survives bootstrap.
>May I install the patch?
Yes.
Richard.
>Martin
>
>>
>>>
>>>
>>> afdo really _grossly_ over-does inlining. And it looks like a total
>>> hack to me.
>>>
>>> It iterates PARAM_EARLY_INLINER_MAX_ITERATIONS but early_inliner
>does
>>> that itself already..
