Rainer Orth <r...@cebitec.uni-bielefeld.de> writes:
> Apart from the (already fixed) go.* dejagnu errors, I noticed another
> problem: the libgo net test now fails on Solaris, but only with Sun ld:
>
> Undefined first referenced
> symbol in file
> getaddrinfo _gotest_.o (symbol belongs to implicit
> dependency /lib/amd64/libsocket.so.1)
> freeaddrinfo _gotest_.o (symbol belongs to implicit
> dependency /lib/amd64/libsocket.so.1)
> gai_strerror _gotest_.o (symbol belongs to implicit
> dependency /lib/amd64/libsocket.so.1)
> ld: fatal: symbol referencing errors. No output written to a.out
> collect2: error: ld returned 1 exit status
> FAIL: net
>
> It seems like the test wants to be linked with -lsocket directly. It
> wasn't run before by default (though I'm pretty sure it worked if one
> included it). The latest merge has lost support for
> GCCGO_RUN_ALL_TESTS.
Running the net test now is intentional--it used to depend on an
Internet connection, but it no longer does.
I think this patch will fix the problem. Bootstrapped and ran libgo
testsuite on x86_64-unknown-linux-gnu. Committed to mainline.
Ian
diff -r ad2a90a01a92 libgo/Makefile.am
--- a/libgo/Makefile.am Mon Sep 26 14:48:33 2011 -0700
+++ b/libgo/Makefile.am Mon Sep 26 15:31:29 2011 -0700
@@ -1761,6 +1761,8 @@
CHECK = \
GC="$(GOC) $(GOCFLAGS) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
export GC; \
+ GOLIBS="$(MATH_LIBS) $(NET_LIBS)"; \
+ export GOLIBS; \
RUNTESTFLAGS="$(RUNTESTFLAGS)"; \
export RUNTESTFLAGS; \
MAKE="$(MAKE)"; \
diff -r ad2a90a01a92 libgo/testsuite/gotest
--- a/libgo/testsuite/gotest Mon Sep 26 14:48:33 2011 -0700
+++ b/libgo/testsuite/gotest Mon Sep 26 15:31:29 2011 -0700
@@ -16,7 +16,7 @@
GC=${GC:-gccgo}
GL=${GL:-${GC-gccgo}}
-GOLIBS=
+GOLIBS=${GOLIBS:-}
export GC GL GOLIBS
NM=${NM:-nm}
