Hi!
On Wed, Mar 29, 2017 at 04:11:19PM -0500, Peter Bergner wrote:
> This passed bootstrap and regtesting on powerpc64le-linux and
> powerpc64-linux (testsuite in both 32-bit and 64-bit). Ok for mainline?
> Ok for the open release branches too?
Okay. A few nits below. Thanks!
> gcc/testsuite/
> PR target/80246
> * gcc.target/powerpc/dfp-builtin-1.c (dxex, dxexq): Update return types.
> (diex, diexq): Update argment types.
Typo ("argument").
> Index: gcc/testsuite/gcc.target/powerpc/pr80246.c
> ===================================================================
> --- gcc/testsuite/gcc.target/powerpc/pr80246.c (nonexistent)
> +++ gcc/testsuite/gcc.target/powerpc/pr80246.c (working copy)
> @@ -0,0 +1,40 @@
> +/* { dg-do compile { target { powerpc*-*-linux* } } } */
> +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
> +/* { dg-skip-if "" { powerpc*-*-*spe* } { "*" } { "" } } */
> +/* { dg-require-effective-target dfp } */
You can leave off the default arguments "*" "". Do we really need to
explicitly skip on Darwin and SPE if there is a test for DFP anyway?
> +/* { dg-final { scan-assembler-times "dxex " 1 } } */
> +/* { dg-final { scan-assembler-times "dxexq " 1 } } */
> +/* { dg-final { scan-assembler-times "diex " 1 } } */
> +/* { dg-final { scan-assembler-times "diexq " 1 } } */
> +/* { dg-final { scan-assembler-not "bl __builtin" } } */
> +/* { dg-final { scan-assembler-not "drintn\\." } } */
> +/* { dg-final { scan-assembler-not "drintnq\\." } } */
> +/* { dg-final { scan-assembler-not "dctfix" } } */
> +/* { dg-final { scan-assembler-not "dctfixq" } } */
If there is no "dctfix" there surely is no "dctfixq" either (i.e., your
regexen aren't very tight).
Segher
