On Tue, Mar 28, 2017 at 11:35:35AM +0200, Thomas Schwinge wrote:
> I noticed that in C++, for a directive like:
>
> #pragma acc parallel default (hello)
>
> ... we currently print two error messages for the same location:
>
> [...]:35:30: error: expected 'none' before 'hello'
> [...]:35:30: error: expected ')' before 'hello'
>
> I think it should be enough to just print the first syntax error (which
> is what we do for C). I also generally beefed up testing of the OpenACC
> default clause in C, C++, Fortran. OK for trunk in next stage 1 (I
> suppose)? For now committed to gomp-4_0-branch in r246526:
>
> commit b11ff2d0f10ef2e2005ccac0d84a02c39117ef9a
> Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
> Date: Tue Mar 28 09:34:03 2017 +0000
>
> OpenACC default clause maintenance
>
> gcc/cp/
> * parser.c (cp_parser_omp_clause_default): Avoid printing more
> than one syntax error message.
> gcc/testsuite/
> * c-c++-common/goacc/data-default-1.c: Remove file.
> * c-c++-common/goacc/default-1.c: New file.
> * c-c++-common/goacc/default-2.c: Likewise.
> * c-c++-common/goacc/default-3.c: Likewise.
> * c-c++-common/goacc/default-4.c: Likewise.
> * gfortran.dg/goacc/default.f95: Remove file.
> * gfortran.dg/goacc/default-1.f95: New file.
> * gfortran.dg/goacc/default-2.f: Likewise.
> * gfortran.dg/goacc/default-3.f95: Likewise.
> * gfortran.dg/goacc/default-4.f: Likewise.
The parser.c change is fine for stage1, but I wonder why are you removing
the tests. If you want to rename them and perhaps update, state so in the
ChangeLog and svn mv them, but the removals + addition without any link looks
weird.
Jakub
