Toma Tabacu <toma.tab...@imgtec.com> writes: > The pic-3,4.c and pie-3,4.c tests are failing for some configurations of > mips*-*-linux-*. > > This is because PIC is always on for MIPS Linux by default, except when the > compiler is built with --with-mips-plt, in which case PIC is on by default > only > for the n64 ABI, because in this case -mplt "has no effect without '-msym32'", > to quote the documentation, so -mplt is not passed by default. > > Richard Sandiford also talked about this in the summary of a patch which was > skipping a test for mips*-*-linux-* because of PIC: > https://gcc.gnu.org/ml/gcc-patches/2009-01/msg00801.html > > Therefore, I think the most reasonable solution would be to just skip these > tests for mips*-*-linux-*. The patch below does so. > > Tested with mips-mti-linux-gnu. > > Catherine, Matthew what do you think ?
Given the acceptance that MIPS PIC behaviour is semi-unique then checking MIPS complies with the rules around pre-processor behaviour doesn't add much value. I'm happy to skip these tests on the basis that software can't make the same assumptions about MIPS and __PIC__ as other architectures do. OK to commit. Thanks, Matthew
