Hi Tom, > On 23/03/17 18:25, Mike Stump wrote: >> On Mar 23, 2017, at 8:46 AM, Tom de Vries <tom_devr...@mentor.com> wrote: >>> >>> I've run the gcc testsuite for target nvptx-none and ran into "test for >>> excess errors" FAILs due to: >>> ... >>> sorry, unimplemented: target cannot support alloca. >> >> We'd encourage ports to support alloca. :-) >> >>> OK for trunk for stage1? >> >> Ok. Ok for release branches and trunk as well, if you want. I'd >> recommend trunk, if your port is meant to work and test out nicely in gcc >> 7. >> > > Committed to trunk.
seems you didn't properly test this patchset. It caused +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++11 (test for warnings, line 24) +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++11 (test for warnings, line 34) +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++11 (test for excess err ors) +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++14 (test for warnings, line 24) +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++14 (test for warnings, line 34) +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++14 (test for excess err ors) +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++98 (test for warnings, line 24) +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++98 (test for warnings, line 34) +FAIL: c-c++-common/Wimplicit-fallthrough-7.c -std=gnu++98 (test for excess err ors) everywhere. Adding that dg-require-effective-target line requires adjusting dg-warning etc. line numbers. Fixed as follows, installed on mainline after checking with the appropriate runtest invocations (for c and c++) on x86_64-pc-linux-gnu. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University 2017-03-24 Rainer Orth <r...@cebitec.uni-bielefeld.de> * c-c++-common/Wimplicit-fallthrough-7.c: Adjust dg-warning line numbers.
# HG changeset patch # Parent 288df338f490e514591c89d11734d7de56f62460 Adjust c-c++-common/Wimplicit-fallthrough-7.c line numbers diff --git a/gcc/testsuite/c-c++-common/Wimplicit-fallthrough-7.c b/gcc/testsuite/c-c++-common/Wimplicit-fallthrough-7.c --- a/gcc/testsuite/c-c++-common/Wimplicit-fallthrough-7.c +++ b/gcc/testsuite/c-c++-common/Wimplicit-fallthrough-7.c @@ -21,8 +21,8 @@ f (int i) switch (i) { case 1: - { /* { dg-warning "statement may fall through" "" { target c } 23 } */ - int a[i]; /* { dg-warning "statement may fall through" "" { target c++ } 24 } */ + { /* { dg-warning "statement may fall through" "" { target c } 24 } */ + int a[i]; /* { dg-warning "statement may fall through" "" { target c++ } 25 } */ } case 2: bar (99); @@ -31,8 +31,8 @@ f (int i) switch (i) { case 1: - for (int j = 0; j < 10; j++) /* { dg-warning "statement may fall through" "" { target c } 33 } */ - map[j] = j; /* { dg-warning "statement may fall through" "" { target c++ } 34 } */ + for (int j = 0; j < 10; j++) /* { dg-warning "statement may fall through" "" { target c } 34 } */ + map[j] = j; /* { dg-warning "statement may fall through" "" { target c++ } 35 } */ case 2: bar (99); }