On 03/13/2017 05:05 PM, Jason Merrill wrote:
It looks like you're ignoring the access for all base destructors; handling this in synthesized_method_base_walk would let you limit the change to vbases with virtual destructors. That function also already handles ignoring access control for an inherited constructor.
d'oh! you're right. I was in two minds about ignoring access at all -- and xfailing that testcase for the moment. That would avoid an unfortunate possible future where the DR resolves to revert to the pre DR 1658 behaviour for dtors. thoughts?
nathan -- Nathan Sidwell