On 10/03/17 19:36 +0800, Xi Ruoyao wrote:
Hi,

This was resent to be in both libstdc++ and gcc-patches list.

Thanks.

The ill-formed checking in binary_heap::push_heap has made it
O(n). Remove this checking.

The checking certainly looks redundant, I wouldn't say ill-formed
though (that's a formal term in the C++ standard meaning the code
isn't valid C++).

Since assert_valid also checks if (*this) is a legal heap, we can
remove is_heap and the assertions using it completely.

The patch looks good, and since you're just removing code I don't
think we need a copyright assignment. I'll get this applied to the
active branches, thanks!

Reply via email to